Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming main files and creating modules for the med-diagnosis pattern #310

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Renaming main files and creating modules for the med-diagnosis pattern #310

wants to merge 7 commits into from

Conversation

abhatt-rh
Copy link
Collaborator

@abhatt-rh abhatt-rh commented Sep 19, 2023 •
edited
Loading

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhatt-rh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhatt-rh abhatt-rh force-pushed the 1193-modular branch 2 times, most recently from aa8cb9b to 8ae400e Compare October 9, 2023 19:19
@abhatt-rh abhatt-rh changed the title Renaming main files for the med-diagnosis pattern for modular docs Renaming main files and creating modules for the med-diagnosis pattern Oct 9, 2023
@mbaldessari
Copy link
Contributor

mbaldessari commented Oct 10, 2023 •
edited
Loading

This is an automated message:

You can preview this docs PR at http://310.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

@abhatt-rh abhatt-rh force-pushed the 1193-modular branch 2 times, most recently from 404f63e to f6bb3d0 Compare October 10, 2023 16:52
@abhatt-rh
Copy link
Collaborator Author

Hi @danmacpherson PTAL. Thanks!

danmacpherson
danmacpherson reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@danmacpherson danmacpherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Avani,

A few minor suggestions, and a few other things:

  • I couldn't seem to comment on the troubleshooting section since it looks like it's largely unchanged and so I can't leave feedback on any diff. This might need to be rechecked as I noticed a few things that needed some style and consistency.
  • Likewise I think there's something odd with the title levels in the Troubleshooting section.
  • There are a fair few videos/animations in this content. I wonder if we can include these things in our enterprise docs. Something to check out.

modules/med-about-medical-diagnosis.adoc Outdated Show resolved Hide resolved
modules/med-setup-aws-s3-bucket-with-utilities.adoc Outdated Show resolved Hide resolved
modules/med-preparing-for-deployment.adoc Outdated Show resolved Hide resolved
modules/med-preparing-for-deployment.adoc Show resolved Hide resolved
modules/med-preparing-for-deployment.adoc
$ git push origin my-branch
----

. To deploy the pattern, you can use the link:/infrastructure/using-validated-pattern-operator/[{validated-patterns-op}]. If you use the Operator to deploy the pattern, skip to the _Verification_ section of this procedure.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step might be better suited for the Deploying the Medical Diagnosis pattern section. E.g. say you can deploy the pattern either with the operator or with the command line

modules/med-troubleshooting-deployment.adoc Show resolved Hide resolved
modules/med-about-customizing-pattern.adoc Outdated Show resolved Hide resolved
modules/med-about-customizing-pattern.adoc Outdated Show resolved Hide resolved
modules/med-about-customizing-pattern.adoc Outdated Show resolved Hide resolved
modules/med-about-customizing-pattern.adoc Outdated Show resolved Hide resolved
@abhatt-rh abhatt-rh force-pushed the 1193-modular branch 2 times, most recently from 7d652e3 to 2b603df Compare November 17, 2023 19:59
@abhatt-rh
Copy link
Collaborator Author

Not merging this yet since I have a discussion open to understand why the htmltest fails for files that are renamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmacpherson danmacpherson danmacpherson left review comments

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhatt-rh @mbaldessari @danmacpherson @openshift-merge-robot