This repository has been archived by the owner on Jul 8, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this useful repo available!
Background
When assigning permissions to models, it is possible to use
.anyone
instead of assigning permissions to a specific (type of) user. Example:This works very well when multiple user-types get limited access to a resource based on the same criteria.
Problem
When
anyone
is used in the authorization chain, then no rules are ever matched for any users. Here is a screenshot of the results from a test that I added totest/integration/can.js
Cause
resolver.js
filters out roles that do not have the same user as the current user.Solution
allow rules to be matched if the rule's user is the same as the current user, or if it not
truthy
.Discussion
I've also added a couple of tests to illustrate the problem and solution.