Release 0.2.1 #129
Merged
Release 0.2.1 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@valerymelou sorry, for punking you. Also updated the no_request tests, to actually test proberly. |
|
Also test coverage has finally reached 100% 🥇 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
===========================================
+ Coverage 96.90% 100.00% +3.09%
===========================================
Files 6 6
Lines 97 106 +9
Branches 12 14 +2
===========================================
+ Hits 94 106 +12
+ Misses 1 0 -1
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. |
added 3 commits
June 7, 2024 12:20
valerymelou
approved these changes
Jun 8, 2024
| ): | ||
| """ | ||
| Renders the given CSS class if the request path matches the path of the view. | ||
| :param context: The context where the tag was called. Used to access the request object. | ||
| :param viewnames: The name of the view or views separated by || (include namespaces if any). | ||
| :param css_class: The CSS class to render. | ||
| :param inactive_class: The CSS class to render if the views is not active. | ||
| :param css_inactive_class: The CSS class to render if the views is not active. |
There was a problem hiding this comment.
Just a small grammar error here: if the view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the inactive class and properly document it.
Also add new setting to settings to preset inactive class.