Anvil Rework #367
Merged
Anvil Rework #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solidify the design of
valence_anvilso that most of the boilerplate in the anvil example is eliminated.AnvilLevelis now a component ofInstanceand automatically loads and unloads chunks as clients move around. Events are used to communicate when chunks are loaded and unloaded.Also changes the system message API and introduces the
SendMessagetrait.Checks off a box in #288
Known Issues
min_yis wrong. I plan to fix this in an upcoming redesign of instances and chunks.