NBT path structure #363
Draft
NBT path structure #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing indexing into arrays and named compounds are buggy. But that'll be fixed soon.
i also renamed my parse function cus parse_or_error is pretty repetitive, as it's clear that it returns a result value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this adds functionality for parsing NBT paths
Describe the changes you've made. Link to any issues this PR fixes or addresses.
The changes I have made so far implement an
NbtPathstructure and a parser from aStringto anNbtPath.(from this issue)
#338
this is not fully complete: i have a few questions i need a bit of clarification on:
NbtPathNode? or is that just redundant because I'm already storing owned values (mainly because of escape characters in quoted strings)NbtPathbesidesString? (like&str?)&Compoundor&mut Compoundvalues." -- how should I go about implementing this? i'm having trouble visualizing the structure of a largeCompoundwith many parts and how i'd traverse through itsoo yea that's all for now :p