Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added folder editing capability #69

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Added folder editing capability #69

merged 5 commits into from
Mar 30, 2022

Conversation

valadas
Copy link
Owner

@valadas valadas commented Mar 15, 2022 •
edited
Loading

This is still a work in progress, please do not merge

  • re-architected actions/menus to support editing any type of item
  • implement a permission grid
  • implement the edit form for a folder item

When this is complete, it will cover the folder part of #21

edit-folder

@valadas valadas changed the title WIP: adds folder editing capability Added folder editing capability Mar 29, 2022
@valadas valadas added the enhancement New feature or request label Mar 29, 2022
david-poindexter
david-poindexter approved these changes Mar 30, 2022
View reviewed changes
Copy link

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @valadas 🎉

@david-poindexter
Copy link

Oh, and just a reminder that we need to create an issue on dnn-elements to change the order on the permission grid checkbox selects so that the first time doesn't set deny permissions, but rather allow permissions. I believe that would keep parity with the expected UX.

@valadas
Copy link
Owner Author

valadas commented Mar 30, 2022

Cool, created an issue for it at DNNCommunity/dnn-elements#546

@valadas valadas merged commit bb137ad into resource-manager Mar 30, 2022
@valadas valadas deleted the edit-folder branch April 14, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valadas @david-poindexter