forked from vgvassilev/clad
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix errors due to recursive calling of HandleTopLevelDecl
- Add custom derivative to DerivativeSet: This is required if the definition of the custom derivative is not found in the current translation unit and is linked in from another. Adding it to the set of derivatives ensures that the custom derivative is not differentiated again using numerical differentiation due to an unavailable definition. - Fix recursive processing of DiffRequests: There can be cases where `m_Multiplexer` is not provided. Hence, we don't delay HandleTranslationUnit at the end and it is called repeatedly. This resulted in HandleTopLevelDecl being called recursively (from PerformPendingInstantiations). This commit adds conditional checks to ensure this doesn't perturb the execution of the differentiation plan.
- Loading branch information
Showing
10 changed files
with
146 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,14 @@ | ||
add_clad_unittest(MiscTests | ||
main.cpp | ||
CallDeclOnly.cpp | ||
Defs.cpp | ||
DynamicGraph.cpp | ||
) | ||
|
||
# Create a library from Defs.cpp | ||
add_library(Defs SHARED Defs.cpp) | ||
target_include_directories(Defs PUBLIC ${CMAKE_SOURCE_DIR}/include) | ||
target_link_libraries(Defs PUBLIC stdc++ pthread m) | ||
|
||
# Link the library to the test | ||
target_link_libraries(MiscTests PRIVATE Defs) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
#include "clad/Differentiator/Differentiator.h" | ||
|
||
#include <iostream> | ||
#include <regex> | ||
#include <string> | ||
|
||
#include "gtest/gtest.h" | ||
|
||
double foo(double x, double alpha, double theta, double x0 = 0); | ||
|
||
double wrapper1(double* params) { | ||
const double ix = 1 + params[0]; | ||
return foo(10., ix, 1.0); | ||
} | ||
|
||
TEST(CallDeclOnly, CheckNumDiff) { | ||
auto grad = clad::gradient(wrapper1, "params"); | ||
// Collect output of grad.dump() into a string as it ouputs using llvm::outs() | ||
std::string actual; | ||
testing::internal::CaptureStdout(); | ||
grad.dump(); | ||
actual = testing::internal::GetCapturedStdout(); | ||
|
||
// Check the generated code from grad.dump() | ||
std::string expected = R"(The code is: | ||
void wrapper1_grad(double *params, double *_d_params) { | ||
double _d_ix = 0; | ||
const double ix = 1 + params[0]; | ||
goto _label0; | ||
_label0: | ||
{ | ||
double _r0 = 0; | ||
double _r1 = 0; | ||
double _r2 = 0; | ||
double _r3 = 0; | ||
double _grad0[4] = {0}; | ||
numerical_diff::central_difference(foo, _grad0, 0, 10., ix, 1., 0); | ||
_r0 += 1 * _grad0[0]; | ||
_r1 += 1 * _grad0[1]; | ||
_r2 += 1 * _grad0[2]; | ||
_r3 += 1 * _grad0[3]; | ||
_d_ix += _r1; | ||
} | ||
_d_params[0] += _d_ix; | ||
} | ||
)"; | ||
EXPECT_EQ(actual, expected); | ||
} | ||
|
||
namespace clad { | ||
namespace custom_derivatives { | ||
// Custom pushforward for the square function but definition will be linked from | ||
// another file. | ||
clad::ValueAndPushforward<double, double> sq_pushforward(double x, double _d_x); | ||
} // namespace custom_derivatives | ||
} // namespace clad | ||
|
||
double sq(double x) { return x * x; } | ||
|
||
double wrapper2(double* params) { return sq(params[0]); } | ||
|
||
TEST(CallDeclOnly, CheckCustomDiff) { | ||
auto grad = clad::hessian(wrapper2, "params[0]"); | ||
double x = 4.0; | ||
double dx = 0.0; | ||
grad.execute(&x, &dx); | ||
EXPECT_DOUBLE_EQ(dx, 2.0); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
#include "clad/Differentiator/Differentiator.h" | ||
|
||
double foo(double x, double alpha, double theta, double x0 = 0) { | ||
return x * alpha * theta * x0; | ||
} | ||
|
||
namespace clad { | ||
namespace custom_derivatives { | ||
clad::ValueAndPushforward<double, double> sq_pushforward(double x, | ||
double _d_x) { | ||
return {x * x, 2 * x}; | ||
} | ||
|
||
void sq_pushforward_pullback(double x, double _dx, | ||
clad::ValueAndPushforward<double, double> _d_y, | ||
double* _d_x, double* _d__d_x) { | ||
goto _label0; | ||
_label0: { | ||
*_d_x += _d_y.value * x; | ||
*_d_x += x * _d_y.value; | ||
*_d_x += 2 * _d_y.pushforward; | ||
} | ||
} | ||
} // namespace custom_derivatives | ||
} // namespace clad |