Fix ava testing for Typescript templates
#39
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade `ava` to v6.2.0 and `ink-testing-library` to v4.0.0. Add `@ava/typescript` and `@types/node` to enhance TypeScript support. Adjust `ava` configuration to use `ts-node/register` and refine TypeScript path handling. These changes improve testing capabilities and maintain compatibility with the latest TypeScript features.
Introduce `pretest` script to run `npm run build` before tests. This ensures the code is compiled before testing, preventing runtime errors due to missing build artifacts. This change improves the reliability of the testing process by guaranteeing that the latest code is always tested.
Relocate `test.tsx` to the `source` directory to resolve broken Ava tests. The file was previously misplaced, causing test failures. This change ensures that the test file is correctly located, allowing the test suite to run without issues. No changes were made to the file's contents. Relates to vadimdemedes#34
|
I think it would be better to use |
This is an alternative to something like |
|
CI is failing |
This approach is mentioned here, but noticing the current ava recipe on gitub mentions using I'll take another look this afternoon and see how things look when switching over. CI is failing because of This is the same issue being reported by others in issues like #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have resolved issues with out-of-box testing with the Typescript ink starter, mentioned in #37.
avato v6.2.0 andink-testing-libraryto v4.0.0.@ava/typescriptand@types/nodeto enhance TypeScript support.avaconfiguration to usets-node/registerand refine TypeScript path handling.pretestscript which executesnpm run buildtest.tsxinto thesource/directory, related to Cannot find module 'ink-testing-library' or its corresponding type declarations #34