Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout handling in send message #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add timeout handling in send message #139

wants to merge 1 commit into from

Conversation

Daimakaimura
Copy link
Contributor

  • Added timeout logic to make sure all message send co-routines come back.
  • RPC calls that timeout will return None as status and this will be recorded in the messages.json file

@Daimakaimura Daimakaimura added the bug Something isn't working label Jul 19, 2023
@Daimakaimura Daimakaimura self-assigned this Jul 19, 2023
@AlbertoSoutullo
Copy link
Collaborator

If you have not been able to reproduce the issue, are we sure that this works properly?

@AlbertoSoutullo
Copy link
Collaborator

@Daimakaimura What do we do with this?

@Daimakaimura
Copy link
Contributor Author

@AlbertoSoutullo I would merge just in case.

@AlbertoSoutullo
Copy link
Collaborator

@AlbertoSoutullo I would merge just in case.

Then I will do it once I finish this batch of simulations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoSoutullo AlbertoSoutullo Awaiting requested review from AlbertoSoutullo

Assignees

@Daimakaimura Daimakaimura

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daimakaimura @AlbertoSoutullo