Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHZ game #13

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Update GHZ game #13

merged 4 commits into from
Oct 17, 2024

Conversation

vabarbosa
Copy link
Owner

@vabarbosa vabarbosa commented Sep 8, 2024

Fixes #4

this PR updates

  • the GHZ Game notebook so it can be run with Qiskit 1.2 and also updates an outdated link
  • the GHZ Game python file so it can run with Qiskit 1.2

@vabarbosa vabarbosa self-assigned this Sep 8, 2024
Copy link

@oyin-bee oyin-bee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHZ-Game JupyterLab file
Suggested amendments: Errors on Cell 4, 16, 17, 18, 22, 26, 31, 32, 35, 37, 39, 41, 43, 46, 48, 50, 56, 58, 60

ghzGame.py
Unable to view python file on laptop.

@vabarbosa
Copy link
Owner Author

GHZ-Game JupyterLab file Suggested amendments: Errors on Cell 4, 16, 17, 18, 22, 26, 31, 32, 35, 37, 39, 41, 43, 46, 48, 50, 56, 58, 60

@oyin-bee what are some of these errors you are seeing? did you also have the GHZGame/ghzGame.py downloaded before running through this notebook?

ghzGame.py Unable to view python file on laptop.

this file is used by the notebook so if you are able to run the notebooks successfully then it means this should be OK too.

@vabarbosa vabarbosa requested a review from oyin-bee September 20, 2024 13:21
Copy link

@oyin-bee oyin-bee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, please see error generated in Jupyter

Screenshot 2024-09-20 153806

Copy link

@oyin-bee oyin-bee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Va, A couple of errors were generated, please see screenshots

Screenshot 2024-09-25 165649
Screenshot 2024-09-25 165704
Screenshot 2024-09-25 165720

Copy link

@oyin-bee oyin-bee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Va, re GHZ-Game.ipynb

The code is ok

Please see suggested grammar and spelling changes below: (Line numbering is derived from updated version in split view)

Line 49 Prerequisites = Prerequisites
Line 226 Not rendering text
Line 283 If you are confident with your choices try it out here = If you are confident with your choices, try them out here. (add comma)
Line 283 strategie = strategy
Line 314 Why has the other team a 100% winning strategie while your team does not? = Why does the other team have a 100% winning strategy while your team does not? (add ‘have’; strategy spelling)
Line 316 To find out what they do differently you talk = to find out what they do differently, you talk (add comma)
Line 390 is, but = is(remove comma) but
Line 435 Before we start we need = Before we start, we need
Line 476 Being = being
Line 539 However, (add comma)
Line 730 if you need help, (add comma)
Line 963 state.The (add space)
Line 1235 Entaglement = Entanglement
Line 1239 Pragraphs = Paragraphs

Thank you
I could not add comments - see screenshot below
Screenshot 2024-10-01 124718

@vabarbosa vabarbosa merged commit 0bd98ed into main Oct 17, 2024
@vabarbosa vabarbosa deleted the va-ghz-game branch October 17, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GHZ Game
2 participants