Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border field styles #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juuso-vaadin
Copy link

Description

Border style that Vaadin Start / Lumo Editor generates for inputs is lacking and even breaks some states. This commit patches the missing components.

  • Make sure readonly, disabled, invalid states work
  • Make sure each state can render suitable hover, focus and focus-ring styles
  • Make sure Text Area is styled the same as other inputs
  • Add support for checkbox and radio button

Commit introduces new "common-input-field.css" file which is imported for each input component. This is done to avoid repetitive code.

Note! This commit only has the required styles without the logic to export styles.

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2022

CLA assistant check
All committers have signed the CLA.

@juuso-vaadin
Copy link
Author

Here's how the fields look with updated styles
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants