test: refactor mock setup in maven plugin tests #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring required by changes in vaadin/flow#20465.
|
The Flow change will be backported to 24.5 and 24.4, so probably this PR should also be cherry picked. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 83 83
Lines 2842 2842
Branches 739 739
=======================================
Hits 2633 2633
Misses 158 158
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
tltv
approved these changes
Nov 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
Refactoring required by changes in vaadin/flow#20465. Co-authored-by: Zhe Sun <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
Refactoring required by changes in vaadin/flow#20465. Co-authored-by: Zhe Sun <[email protected]>
taefi
pushed a commit
that referenced
this pull request
Nov 20, 2024
…2912) test: refactor mock setup in maven plugin tests (#2911) Refactoring required by changes in vaadin/flow#20465. Co-authored-by: Marco Collovati <[email protected]> Co-authored-by: Zhe Sun <[email protected]>
taefi
added a commit
that referenced
this pull request
Nov 20, 2024
…2913) test: refactor mock setup in maven plugin tests (#2911) Refactoring required by changes in vaadin/flow#20465. Co-authored-by: Marco Collovati <[email protected]> Co-authored-by: Zhe Sun <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring required by changes in vaadin/flow#20465.