Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable ListSignal in generator-plugin-signals #2810

Open
wants to merge 1 commit into
base: taefi/feat/add-list-signal
Choose a base branch
from

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Oct 9, 2024

Description

This enables the generator-plugin-signals to correctly generate TS services for the endpoints with methods returning instances of ListSignal.

Follow-up for #2775
(Based on #2775)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

This enables the generator-plugin-signals to correctly
generate TS services for the endpoints with methods
returning instances of ListSignal.
Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (ecd0355) to head (c67de25).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           taefi/feat/add-list-signal    #2810      +/-   ##
==============================================================
+ Coverage                       92.51%   92.52%   +0.01%     
==============================================================
  Files                              83       83              
  Lines                            2765     2769       +4     
  Branches                          715      716       +1     
==============================================================
+ Hits                             2558     2562       +4     
  Misses                            156      156              
  Partials                           51       51              
Flag Coverage Δ
unittests 92.52% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant