Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sends beacon request in beforeunload event in Firefox #20198

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mstahv
Copy link
Member

@mstahv mstahv commented Oct 9, 2024

Firefox has a bug/feature that it don't send the beacon in pagehide event.

Fixes #19305

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Firefox has a bug/feature that it don't send the beacon in pagehide event.

Closes #19305
Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

github-actions bot commented Oct 9, 2024

Test Results

1 141 files  ± 0  1 141 suites  ±0   1h 23m 29s ⏱️ - 4m 36s
7 447 tests ± 0  7 397 ✅ +22  50 💤 ±0  0 ❌  - 10 
7 819 runs  +15  7 759 ✅ +37  60 💤 ±0  0 ❌  - 10 

Results for commit e4af719. ± Comparison against base commit 1fbf412.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Oct 9, 2024
@tepi tepi merged commit e554b45 into main Oct 9, 2024
26 checks passed
@tepi tepi deleted the bugfix/firefox-detach-event-on-top-of-main branch October 9, 2024 14:42
vaadin-bot pushed a commit that referenced this pull request Oct 9, 2024
Firefox has a bug/feature that it don't send the beacon in pagehide event.

Closes #19305
vaadin-bot pushed a commit that referenced this pull request Oct 9, 2024
Firefox has a bug/feature that it don't send the beacon in pagehide event.

Closes #19305
vaadin-bot added a commit that referenced this pull request Oct 9, 2024
Firefox has a bug/feature that it don't send the beacon in pagehide event.

Closes #19305

Co-authored-by: Matti Tahvonen <[email protected]>
vaadin-bot added a commit that referenced this pull request Oct 9, 2024
Firefox has a bug/feature that it don't send the beacon in pagehide event.

Closes #19305

Co-authored-by: Matti Tahvonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beacon API based eager UI closing is broken on Firefox and Safari
4 participants