-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use rollup-plugin-postcss-lit with Vite #14295
Conversation
Tested with both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two tests still failing:
Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.844 s <<< FAILURE! - in com.vaadin.flow.uitest.ui.theme.ReusableThemeIT
Error: applicationTheme_GlobalCss_isUsed[ANY_Chrome_](com.vaadin.flow.uitest.ui.theme.ReusableThemeIT) Time elapsed: 0.844 s <<< FAILURE!
Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.791 s <<< FAILURE! - in com.vaadin.flow.webcomponent.ApplicationThemeComponentIT
Error: applicationTheme_GlobalCss_isUsedOnlyInEmbeddeComponent[ANY_Chrome_](com.vaadin.flow.webcomponent.ApplicationThemeComponentIT) Time elapsed: 0.791 s <<< FAILURE!
@mshabarov Updated the PR to also add |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi @web-padawan and @mshabarov, when i performed cherry-pick to this commit to 23.1, i have encountered the following issue. Can you take a look and pick it manually? |
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version. |
Description
Fixes #14142
Added
rollup-plugin-postcss-lit
and configured it to handle all CSS files except those under theme folder.Note the extra entry with
?
is necessary until umbopepato/rollup-plugin-postcss-lit#49 fixed.Another entry added to
excludes
to workaround umbopepato/rollup-plugin-postcss-lit#52Type of change