Catalog qol

[zvfrozel]

pretty comprehensive(?) filtering and sorting functionality in the unit catalog to enhance Quality of Life (ft. ChatGPT)

Code passes style checks but tests haven't been written.

[vEnhance]

• The hints_released_date thing should really be a separate PR, not merged into, but anyway I added it in myself to main so that's a moot point.
• It looks like one of your commits seems to have accidentally broken the symlink to otisweb/templates/socialaccount/base.html. I'll revert this for you and see if it passes tests after making that change.

More comments forthcoming once I actually read the PR and try this on my local server.

[coveralls]

Pull Request Test Coverage Report for Build 11769985289

Details

• 102 of 102 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 91.883%

---

Totals
Change from base Build 11759811135:	0.2%
Covered Lines:	7250
Relevant Lines:	7721

---

💛 - Coveralls

[vEnhance]

This looks really good! I made a few cosmetic changes to personal taste, but overall I think this looks really solid.

If you go ahead and write a few unit tests we can basically merge it in right away since I've checked that it seems to work the way intended.

[zvfrozel]

Thanks 🧡
I (chatgpt) will write the unit tests shortly and update the PR, no problem

[zvfrozel]

Ok, i think we are good to go.

Is it possible to disable linting for specific files? case in point - ruff made the test_catalog_filters function in tests.py look downright ugly.

[vEnhance]

Is it possible to disable linting for specific files?

yes but it's not worth it i think

[vEnhance]

ok i looked at the commit a981959 and in general if you want ruff to put every argument on its own line you should put a trailing comma, and it'll do so, se 1915baf for an example of how to do this

[vEnhance]

alright i think this is good now thanks much, it should be on production momentarily.

thank you for this much-needed pull request!

[zvfrozel]

there is a typo here by the way:

EDIT: probably pull zvfrozel/otis-web:main for 2 minor patches, inluding the typo

[vEnhance]

OK, but in the future feel free to just open a pull request yourself if you have patches like this you want to merge.

[zvfrozel]

Okay