Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy/random.c: fix use of MICROPY_PY_RANDOM_SEED_INIT_FUNC #684

Merged

Conversation

dhalbert
Copy link
Contributor

@dhalbert dhalbert commented Sep 8, 2024

In numpy/random.c:

The preprocessor guard for MICROPY_PY_RANDOM_SEED_INIT_FUNC was not complete: the value was used even if it was undefined.

There were also inconsequential trailing spaces and a trailing newline that were cleaned up by emacs when I edited the file.

@dhalbert
Copy link
Contributor Author

dhalbert commented Sep 8, 2024

FYI, we're merging micropython v1.23 into circuitpython, and this was a blocker (though we may need to turn off some functionality like random if it's not fitting on some boards).

@dhalbert
Copy link
Contributor Author

dhalbert commented Sep 8, 2024

I don't know what to make of the build failures, but I think they are unrelated.

@v923z
Copy link
Owner

v923z commented Sep 9, 2024

I don't know what to make of the build failures, but I think they are unrelated.

Yeah, that's totally unrelated, I'd just let it pass for now. I've meant to fix that, but I forgot. Thanks for bringing it up!

@v923z
Copy link
Owner

v923z commented Sep 9, 2024

In numpy/random.c:

The preprocessor guard for MICROPY_PY_RANDOM_SEED_INIT_FUNC was not complete: the value was used even if it was undefined.

There were also inconsequential trailing spaces and a trailing newline that were cleaned up by emacs when I edited the file.

Many thanks!

@v923z v923z merged commit 1d3ddd8 into v923z:master Sep 9, 2024
13 of 16 checks passed
@dhalbert dhalbert deleted the undef-MICROPY_PY_RANDOM_SEED_INIT_FUNC branch September 9, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants