added first implementation of utils sub-module #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pumelo
suggested changes
Mar 4, 2021
code/utils/utils.c
Outdated
| } | ||
| } | ||
| } else { | ||
| for(uint8_t i = 0; i < len; i++) { |
There was a problem hiding this comment.
use size_t? uint8_t will probably not reach the end condition...
There was a problem hiding this comment.
Yes, this was the issue! with the documented crash.
There was a problem hiding this comment.
Indeed! 😊 Thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address the issue raised in #341
The general problem is that peripheral devices do not necessarily supply data compatible with
ulab's 5 supporteddtypes. However, for the most common tasks, simple conversion functions can be added. With the help of these, arbitrary data formats could be converted to the supporetddtypes. After the conversion, the standardulaboperations can be carried out on the data arrays.In the future, the
utilssub-module could be the place, where useful, but notnumpy-compatible functions working with or returningndarrays could be stored.