Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts https://github.com/v8/node/pull/192 #193

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

gahaas
Copy link

@gahaas gahaas commented Jun 21, 2024

Reverts #192

This PR caused failing tests. Preparation is needed in V8 to allow exceptions to be thrown in fast API callbacks called from the wasm wrapper.

@gahaas gahaas marked this pull request as ready for review June 21, 2024 15:22
@gahaas gahaas changed the title [wasi] Stop using V8 fast API Reverts https://github.com/v8/node/pull/192 Jun 24, 2024
@victorgomes victorgomes merged commit 7f493af into v8:node-ci-2024-06-03 Jun 24, 2024
10 of 15 checks passed
pthier pushed a commit that referenced this pull request Jul 15, 2024
* [wasi] Stop using V8 fast API

* Revert "[wasi] Stop using V8 fast API"

This reverts commit 0d5d171.

* Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)"

This reverts commit 286ed38.
victorgomes pushed a commit that referenced this pull request Aug 22, 2024
* [wasi] Stop using V8 fast API

* Revert "[wasi] Stop using V8 fast API"

This reverts commit 0d5d171.

* Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)"

This reverts commit 286ed38.
pthier pushed a commit that referenced this pull request Oct 2, 2024
* [wasi] Stop using V8 fast API

* Revert "[wasi] Stop using V8 fast API"

This reverts commit 0d5d171.

* Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)"

This reverts commit 286ed38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants