Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement concurrent memcpy for building Python objects into vineyard #1646

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

sighingnow
Copy link
Member

Remove the problematic .buffer property (as it cannot bind the lifetime of the underlying blob to the memoryview object) and add concurrent support for memcpy for faster object building.

Fixes #1631

Copy link
Member

@dashanji dashanji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for claifying!

@sighingnow sighingnow merged commit 89530bf into v6d-io:main Dec 13, 2023
4 of 5 checks passed
@sighingnow sighingnow deleted the ht/concurrent-memcpy branch December 13, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor performance
2 participants