Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jupyter] Add start timestamps and log exit_code #1019

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[Jupyter] Add start timestamps and log exit_code #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d570687
replace time deltas with timestamps + log jupyterlab exit_code
Jan 30, 2024
8c4a1a8
bump jupy chart
Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/jupyter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 0.14.36
version: 0.14.37
apiVersion: v1
appVersion: 3.4.8
name: jupyter
Expand Down
10 changes: 7 additions & 3 deletions stable/jupyter/templates/jupyter-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ data:
## log + timer
start=${SECONDS}
log () {
echo [$(( SECONDS - start ))s] "$*"
echo [$(date)] "$*"
}

{{ include "v3io-configs.script.lookupService" . | indent 4 }}
Expand Down Expand Up @@ -633,6 +633,10 @@ data:


## Start jupyter
log 'Starting jupyter'
log "Starting jupyter lab --no-browser $@"
source activate jupyter
jupyter lab --no-browser $@
jupyter lab --no-browser "$@"

## Log jupyter exit
exit_code=$?
log "Jupyter Lab exited with code $exit_code"
Loading