Skip to content

Commit

Permalink
MinPlatformPkg SerialPortTerminalLib: Fixing CodeQL issue Pointless c…
Browse files Browse the repository at this point in the history
…omparison of unsigned value to zero. (microsoft#282)

## Description

CodeQL is reporting Pointless comparison of unsigned value to zero for a
value derived from an unsigned PCD PcdDefaultTerminalType.


- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested
Ran Local CI.

## Integration Instructions
N/A
  • Loading branch information
apop5 authored and v-jaschen committed Nov 8, 2024
1 parent 8cbbc6e commit 771a08a
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ AddSerialTerminal (
(int) mSerialDevicePath.Uart.StopBits,
(int) DefaultTerminalType));

if (DefaultTerminalType >= 0 &&
DefaultTerminalType < (sizeof (mTerminalType) / sizeof (mTerminalType[0]))) {
if (DefaultTerminalType < (sizeof (mTerminalType) / sizeof (mTerminalType[0]))) {
CopyMem (
(VOID *) &(mSerialDevicePath.TerminalType.Guid),
(VOID *) mTerminalType[DefaultTerminalType],
Expand Down

0 comments on commit 771a08a

Please sign in to comment.