-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ercan et al., CVPRW 2023 #218
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. BTW, [33] has open-source code :) https://github.com/tub-rip/event_based_image_rec_inverse_problem
which is omitted in Table 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you very much for bringing that comment here :) Let me respond and hopefully clarify that now:
In Table 1, what we indicate with the "open source" column is whether that work has its "evaluation" code/setup open, meaning that one can run a script and generate the quantitative results in that work, similar to this and that. I think being able to reproduce quantitative results is important since it is not feasible for one to confirm that the code worked as expected just by looking at the qualitative results. I believe some years-old issues on code repositories of earlier works (examples: 1, 2, 3) indicate that this is indeed something needed in the community.
Given that clarification, please let us know if we are still missing something in Table 1, particularly related to [33] :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. I think it is a matter of my expectations: when I read "Open Source" in the column header and there is one method/reference per row, I thought it was about listing the references that had the code available vs those that did not. For example, the first row [27] has no code available. Maybe a header "Eval. code available" would have been better. No worries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your comments, you are right, it could have been explained better (if we weren't trying so hard to fit into the page limit).
Looking forward to the workshop!