-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provisionSystem API with proxy option #9464
Add provisionSystem API with proxy option #9464
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
33b9123
to
f56cdb3
Compare
Using web ui it is possible to schedule system provisioning through specific proxy. This is not possible using any API call. This commit adds this missing provisionSystem API call and related unit tests. Automatic proxy detection based on request headers is preserved.
f56cdb3
to
78b7605
Compare
What does this PR change?
Using web ui it is possible to schedule system provisioning through specific proxy. This is not possible using any API call. This commit adds this missing provisionSystem API call and related unit tests.
Automatic proxy detection based on request headers is preserved.
GUI diff
No difference.
Documentation
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25636
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!