Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality Intelligence #9431

Conversation

srbarrios
Copy link
Member

@srbarrios srbarrios commented Nov 4, 2024

What does this PR change?

This PR implement some handlers to report system metrics with the aim to achieve this card: https://github.com/SUSE/spacewalk/issues/24507

Additionally, it implements the necessary steps to extract the metrics from our Continuous Integration test suite.

GUI diff

No difference.

  • DONE

Documentation

  • Documentation needed: I will include it as part of this PR

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • Cucumber tests were added

  • DONE

Links

Ports:

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests" (Test skipped, there are no changes to test)
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9431/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9431/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@srbarrios srbarrios changed the title Quality intelligence bootstrap onboarding synchronization PoC: Quality Intelligence Nov 4, 2024
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch 6 times, most recently from 2a54b8f to cf7fb51 Compare November 7, 2024 18:41
@srbarrios srbarrios marked this pull request as ready for review November 7, 2024 18:43
@srbarrios srbarrios requested a review from a team as a code owner November 7, 2024 18:43
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch 3 times, most recently from 4c14bd2 to 648ae32 Compare November 7, 2024 18:53
@srbarrios srbarrios changed the title PoC: Quality Intelligence Quality Intelligence Nov 7, 2024
szachovy
szachovy previously approved these changes Nov 7, 2024
Copy link
Contributor

@szachovy szachovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are optional, but please respond to them.

testsuite/features/support/code_coverage.rb Show resolved Hide resolved
testsuite/features/support/code_coverage.rb Outdated Show resolved Hide resolved
testsuite/features/support/database_handler.rb Outdated Show resolved Hide resolved
testsuite/features/support/system_monitoring.rb Outdated Show resolved Hide resolved
testsuite/Gemfile Outdated Show resolved Hide resolved
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch from 648ae32 to cca5f41 Compare November 8, 2024 09:48
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch 3 times, most recently from 521f789 to e3b1d1e Compare November 8, 2024 10:09
@srbarrios srbarrios requested a review from a team November 8, 2024 10:38
szachovy
szachovy previously approved these changes Nov 8, 2024
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch 2 times, most recently from 6f7ae82 to 04fd163 Compare November 8, 2024 14:23
testsuite/documentation/software-components.md Outdated Show resolved Hide resolved
testsuite/documentation/software-components.md Outdated Show resolved Hide resolved
szachovy
szachovy previously approved these changes Nov 8, 2024
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch 2 times, most recently from 006824a to d548e3d Compare November 8, 2024 15:49
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch 3 times, most recently from 1e5c20a to 2f6a8df Compare November 11, 2024 11:22
@srbarrios srbarrios force-pushed the quality-intelligence-bootstrap-onboarding-synchronization branch from 2f6a8df to dc4a3a3 Compare November 11, 2024 11:44
@srbarrios srbarrios merged commit 3746f52 into uyuni-project:master Nov 11, 2024
16 checks passed
@srbarrios srbarrios deleted the quality-intelligence-bootstrap-onboarding-synchronization branch November 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants