Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React keys in subscribe-channels (issue #8729) #9386

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jhonnyV-V
Copy link
Contributor

@jhonnyV-V jhonnyV-V commented Oct 17, 2024

What does this PR change?

Add a key property in multiple elements, this fixes #8729

GUI diff

No difference.

Documentation

  • No documentation needed

Test coverage

  • No tests: already covered

Links

Issue(s): #8729

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

@jhonnyV-V jhonnyV-V requested a review from a team as a code owner October 17, 2024 23:01
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9386/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9386/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@Etheryte
Copy link
Member

Etheryte commented Oct 21, 2024

Thanks a lot for stopping by and taking the time to fix this, that's very kind of you. I have one small nitpick about the type annotation, but outside of that this looks good. 👍

Could you please run yarn lint to fix the premerge checks?

….tsx and subscribe-channels/subscribe-channels.tsx

fix: remove type annotation

fix: running lint
@jhonnyV-V
Copy link
Contributor Author

Thanks a lot for stopping by and taking the time to fix this, that's very kind of you. I have one small nitpick about the type annotation, but outside of that this looks good. 👍

Could you please run yarn lint to fix the premerge checks?

sure, I just did the linting and removed the type annotation, I squashed the commits and force pushed to keep the history clean

Copy link
Member

@Etheryte Etheryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated. That looks good, approved.

Fyi you will not be able to merge this PR yourself, I will merge it once our release cycle has branches open again.

@deneb-alpha
Copy link
Contributor

failures on tests are unrelated. checked with QE team before merging

@deneb-alpha deneb-alpha merged commit d7095c4 into uyuni-project:master Oct 23, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing React key in software channels page
3 participants