-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React keys in subscribe-channels (issue #8729) #9386
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Thanks a lot for stopping by and taking the time to fix this, that's very kind of you. I have one small nitpick about the type annotation, but outside of that this looks good. 👍 Could you please run |
….tsx and subscribe-channels/subscribe-channels.tsx fix: remove type annotation fix: running lint
sure, I just did the linting and removed the type annotation, I squashed the commits and force pushed to keep the history clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, much appreciated. That looks good, approved.
Fyi you will not be able to merge this PR yourself, I will merge it once our release cycle has branches open again.
failures on tests are unrelated. checked with QE team before merging |
What does this PR change?
Add a key property in multiple elements, this fixes #8729
GUI diff
No difference.
Documentation
Test coverage
Links
Issue(s): #8729
Changelogs
If you don't need a changelog check, please mark this checkbox: