Adapt channel change #8943
Merged
Adapt channel change #8943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
mcalmer
force-pushed
the
adapt-channel-change
branch
2 times, most recently
from
e6d2925
to
dd5c148
Compare
mcalmer
force-pushed
the
adapt-channel-change
branch
3 times, most recently
from
ef30b3a
to
dd5dd47
Compare
mcalmer
requested review from
lucidd and
mackdk
and removed request for
a team
lucidd
reviewed
Aug 20, 2024
mackdk
previously approved these changes
Aug 20, 2024
lucidd
previously approved these changes
Aug 21, 2024
These tests are repeated from SystemHandlerTests and do not belong to ChannelSoftwareHandlerTest. Nothing from ChannelSoftwareHandler is called in these tests
mcalmer
force-pushed
the
adapt-channel-change
branch
from
769c6aa
to
e08a872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Currently we have 2 ways in the code how channels are changed.
The first (old) way has the benefit, that also offline clients change the channels and it can be changed on the client also later by just applying the channel state.
The 2nd way is complicated as new access tokens needs to be generated, but the channel pillar data needs to be manually compiled and send via the state.apply instead of using the standard way by reading the database.
Offline minions will not change the channels at all which is a requirement of some users.
This PR try to go back to the 1st (old) way to just perform the changes in the Database and send out the result to the client.
If that fail, we do not invalidate the tokens anymore as a new state.apply can fix the situation later.
For this we have to remove asynchronous handling of of things which were done in ChannelsChangeEventMessageAction as the following state.apply for the channels require to have the data in the database and this event is waiting on the main event to be finished.
In this one case we execute now this Action Syncronous, while on Distupgrade and other cases we still use it via the message queue.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Unit tests were adapted
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/23251
Port(s): ???
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!