Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiting text checks between event click link #7373

Merged

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Aug 7, 2023

What does this PR change?

Add waiting steps between click during the onboarding waiting around event tab.
During the BV, some of the refresh methods were starting before the page loaded ( same than #7371 )

Links

Related to : https://github.com/SUSE/spacewalk/issues/22175

Changelogs

  • No changelog needed

@maximenoel8 maximenoel8 requested a review from a team as a code owner August 7, 2023 06:42
@maximenoel8 maximenoel8 changed the title Add waiting test check between event click link Add waiting text checks between event click link Aug 7, 2023
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Maxime!

@@ -142,12 +142,16 @@
# same name in the events history - however, that's the best we have so far.
steps %(
When I follow "Events"
And I wait until I see "Pending Events" text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first step might raise a timeout depending the state and the tab you are isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my tests, clicking on Events tab always bring you to Pending sub-tab. I will keep an eye on this

@maximenoel8 maximenoel8 merged commit 0a0b7d3 into uyuni-project:master Aug 7, 2023
4 of 8 checks passed
@maximenoel8 maximenoel8 deleted the check_events_page_loaded branch August 7, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants