Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifier.IsCompatibleWithPointer: add missing brackets around (DomainSelector | Domain.Pointer) #1298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptomin
Copy link
Collaborator

@ptomin ptomin commented Nov 30, 2023

No description provided.

@uxmal
Copy link
Owner

uxmal commented Dec 11, 2023

@ptomin: I've added the fixes suggested in this PR to the master branch in another commit. Can you rebase this PR on top of master and see if there are any problems? It's possible this PR may have become redundant.

@ptomin ptomin force-pushed the fix-is-compatible-with-pointer branch from 13e03c7 to ba91740 Compare December 12, 2023 17:26
@ptomin
Copy link
Collaborator Author

ptomin commented Dec 12, 2023

@ptomin: I've added the fixes suggested in this PR to the master branch in another commit. Can you rebase this PR on top of master and see if there are any problems? It's possible this PR may have become redundant.

Done.
But haven't seen your "another commit" at the master branch.

@uxmal
Copy link
Owner

uxmal commented Dec 18, 2023

@ptomin, please rebase again, I'm having difficulties with typing-fixes branch. It will have to wait.

@ptomin ptomin force-pushed the fix-is-compatible-with-pointer branch from b8128c8 to 94f028e Compare December 21, 2023 15:42
@ptomin
Copy link
Collaborator Author

ptomin commented Dec 21, 2023

Rebased. But there are still regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants