Install clang-tidy-19 rather than use pip install #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/add_clang_tidy_19
branch
3 times, most recently
from
b3e42a2 to
05c02a3
Compare
hvdijk
reviewed
Nov 19, 2024
hvdijk
reviewed
Nov 19, 2024
coldav
force-pushed
the
colin/add_clang_tidy_19
branch
3 times, most recently
from
08038d6 to
8203130
Compare
hvdijk
reviewed
Nov 19, 2024
coldav
force-pushed
the
colin/add_clang_tidy_19
branch
from
8203130 to
42994ce
Compare
pip installing clang-tidy-19 on aarch64 was causing a full rebuild rather than just fetching. This resolves this by using the apt-get install method.
coldav
force-pushed
the
colin/add_clang_tidy_19
branch
from
42994ce to
e9ad791
Compare
hvdijk
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves this by using the apt-get install method.
Overview
Switch to using apt-get install rather than pip for clang-tidy-19
Reason for change
pip installing clang-tidy-19 on aarch64 was causing a full rebuild rather than just fetching.