Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Google analytics? #3

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Drop Google analytics? #3

merged 1 commit into from
Apr 25, 2024

Conversation

jheer
Copy link
Member

@jheer jheer commented Apr 25, 2024

I don't have a super strong feeling about this, but we haven't been using the analytics and maybe we want to start fresh and reconsider what we want here. Meanwhile, I was seeing an error/warning associated with this code.

@jheer jheer requested a review from mcnuttandrew April 25, 2024 22:10
Copy link
Collaborator

@mcnuttandrew mcnuttandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea. if we want analytics there are less invasive ways to provide em (in the past i've used a self hosted https://umami.is/ to pretty good effect), but it also might not be necessary at all.

@mcnuttandrew mcnuttandrew merged commit 23db2ed into main Apr 25, 2024
1 check passed
@jheer jheer deleted the jh/analytics branch April 25, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants