Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deno target to rollup build script #281

Closed
wants to merge 1 commit into from

Conversation

lsh
Copy link
Contributor

@lsh lsh commented May 31, 2022

This is a proof of concept to display a working build for #280.

Currently the Arquero distribution on Skypack does not work with Deno. This PR allows a cursory look into adding Deno as a distribution target. To see it in use, build Arquero normally (yarn build), then in a Deno REPL (assuming the current working directory is Arquero's root):

const aq = await import('./dists/arquero.deno.js');

plugins: [
replace({
values: { 'apache-arrow': 'https://cdn.skypack.dev/[email protected]' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
values: { 'apache-arrow': 'https://cdn.skypack.dev/[email protected]' },
values: { 'apache-arrow': 'https://cdn.jsdelivr.net/npm/[email protected]/+esm' },

Note that this means arguer needs #277, I think.

@jheer
Copy link
Member

jheer commented Jul 11, 2024

Closing out due to the age of the PR and its draft status. But I'd be happy to consider an updated PR for a Deno build on top of Arquero v6 (#358)!

@jheer jheer closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants