Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOL] - ESLint on save #116

Closed
wants to merge 4 commits into from
Closed

[QOL] - ESLint on save #116

wants to merge 4 commits into from

Conversation

kevin-pierce
Copy link
Contributor

This is simply a minor QoL upgrade ; with these changes, ESLint should now run on-save (for anyone using VSCode). Initially, this might cause some ugly diffs in your files (due to the restructuring of imports) but hopefully this makes linting a little less annoying going forward.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • If I have made API changes, I have updated the REST API Docs
  • IF I have made changes to the db/models, I have updated the Data Models Page
  • I have updated other Docs as needed

@kevin-pierce kevin-pierce marked this pull request as draft June 22, 2023 04:51
@kevin-pierce kevin-pierce added the improvement involves improving code label Jun 22, 2023
@kevin-pierce kevin-pierce marked this pull request as ready for review June 23, 2023 01:43
Copy link
Collaborator

@connor-bechthold connor-bechthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with this but couple of things

  • If we do this we should probably include all the reformatting that's done because this is going to bloat future PR's
  • Also just realized, the linter that we typically run is through yarn, and not ESlint. Curious why we have both? If the yarn linter works for us now, we can probably stick with that instead of going through the hassle of reformatting things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement involves improving code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants