[FIX] - Pagination Component redundant fetches #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-pierce
changed the title
kevin-pierce
added
front-end
connor-bechthold
requested changes
Jun 22, 2023
There was a problem hiding this comment.
It's crazy how much better of a user experience this is 🧑🍳
Couple of things:
- I think the flow would be even better if when you click enter, you're deselected from the box
- Not sure if this is out of the scope of this ticket, but do we also want to consider disabling the inputs while the records are being fetched? cc @Safewaan
kevin-pierce
commented
Jun 22, 2023
Comment on lines
55
to
75
| // Only fetch records if a valid page num is present AND the page num has changed | ||
| const fetchRecords = () => { | ||
| if (!Number.isNaN(userPageNum) && userPageNum !== pageNum) { | ||
| getRecords(userPageNum); | ||
| } | ||
| } | ||
|
|
||
| const handleBlur = (event: React.FocusEvent<HTMLInputElement>) => { | ||
| // Treat the enter key as an alt method of triggering onBlur (lose focus) | ||
| const handleKeyUp = (event: any) => { | ||
| if (event.keyCode === 13) { | ||
| event.target.blur(); | ||
| } | ||
| } | ||
|
|
||
| const handleBlur = () => { | ||
| if (Number.isNaN(userPageNum)) { | ||
| setUserPageNum(pageNum); | ||
| return; | ||
| } | ||
| fetchRecords() | ||
| }; |
There was a problem hiding this comment.
This control flow is a little weird, so I thought I'd comment it to explain:
Two ways to trigger a fetch:
- Exiting focus from the textbox (Clicking outside of it) ; handleBlur
- Hitting the enter key ; handleKeyUp
handleBlur:
- Checks if number is present ; if not, reset to the previous number and terminate
- If a valid number is present, initiate a fetch
handleKeyUp:
- Checks if key-up (triggered once a user "stops" pressing a key) is == 13 (the key code for the
ENTERkey) ; if true, then this will force ablurevent (triggering thehandleBlurfunction)
Let's see what the performance of pagination looks like after the improvements and discuss with the designers |
connor-bechthold
approved these changes
Jun 24, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue link
Pagination Component - Prevent redundant / unintentional fetches
Implementation description
fetchRecordsfunction to actually perform the getonKeyUpevent handler to trigger fetchhandleNumberInputChangefunction to only update the input valueSteps to test
tabor clicking outside of it) will refetch log recordsWhat should reviewers focus on?
Checklist