Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lesson drag and drop #208

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add lesson drag and drop #208

wants to merge 2 commits into from

Conversation

mslwang
Copy link
Contributor

@mslwang mslwang commented Jul 19, 2022

Implementation Description

Brief summary of PR

Screenshots

Visual depiction of PR

What should reviewers focus on?

Testing Procedure

  • What test(s) should we run to make sure your code works?
    • What ways could the input be wrong?
    • Is it secure? Could nefarious users access/break it?

Things to Note

  • Additional dependencies/libraries you've added?
  • Things you'd want to know when coming back to the code after a few months

Checklist

  • Ensure code follows style guide by running the linters
  • I have updated the documentation or deemed it unnecessary
  • I have linked the relevant issue in this PR
  • I have requested a review from the PL, as well as other dev(s) (and designers if necessary)

@mslwang
Copy link
Contributor Author

mslwang commented Jul 19, 2022

TODO: Fix jumping transition animation issue due to this beautiful dnd bug: https://stackoverflow.com/questions/59130533/items-jumping-when-dropping-on-react-beautiful-dnd

@mslwang mslwang changed the title Add lesson draggability Add lesson drag and drop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant