Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add seen/delete notifications #38

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Conversation

jeessh
Copy link
Collaborator

@jeessh jeessh commented Dec 16, 2023

Notion ticket link

Ticket Name

Implementation description

  • Added seen and delete functionality to notifications

Steps to test

  1. npx prisma migrate dev
  2. npx prisma generate
  3. docker-compose up --build
  4. test in postman

What should reviewers focus on?

  • ./implementations/NotificationService.ts: deleteNotification, seenNotification
  • delete only sets it to isDeleted, not deleting the actual notif

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jeessh jeessh changed the title Feat: add seen/delete notifications feat: add seen/delete notifications Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants