Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy #611

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: copy #611

merged 2 commits into from
Nov 14, 2023

Conversation

jfdoming
Copy link
Contributor

@jfdoming jfdoming commented Nov 2, 2023

Notion ticket link

n/a, we noticed this while discussing handoff

Implementation description

  • "Jump Math" -> "JUMP Math" (this matches how the name is stylized on their website and in their emails)
  • Change wording of verification email, since it was blatantly inaccurate before

Steps to test

  1. n/a

What should reviewers focus on?

  • Are there improvements to copy?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jfdoming jfdoming temporarily deployed to staging November 2, 2023 02:24 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 2, 2023

Visit the preview URL for this PR (updated for commit a0b27e9):

https://jump-math-staging--pr611-julian-minor-copy-fi-6toxb40q.web.app

(expires Thu, 09 Nov 2023 02:27:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

@jfdoming jfdoming merged commit 1bf6443 into staging Nov 14, 2023
7 checks passed
@jfdoming jfdoming deleted the julian/minor-copy-fixes branch November 14, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants