Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show search filters unconditionally #606

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

carissa-tang
Copy link
Collaborator

@carissa-tang carissa-tang commented Oct 29, 2023

Notion ticket link

Fix Search Bar For Empty Results

Implementation description

Steps to test

image

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@carissa-tang carissa-tang temporarily deployed to staging October 29, 2023 19:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 29, 2023

Visit the preview URL for this PR (updated for commit 7fff2a6):

https://jump-math-staging--pr606-carissa-fix-search-b-xi8pvfr0.web.app

(expires Mon, 06 Nov 2023 02:39:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

@carissa-tang carissa-tang temporarily deployed to staging October 30, 2023 02:35 — with GitHub Actions Inactive
@carissa-tang carissa-tang merged commit 5049a31 into staging Oct 30, 2023
4 checks passed
@carissa-tang carissa-tang deleted the carissa/fix-search-bar branch October 30, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants