Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove GraphQL upload limits #602

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: remove GraphQL upload limits #602

merged 1 commit into from
Oct 4, 2023

Conversation

carissa-tang
Copy link
Collaborator

@carissa-tang carissa-tang commented Oct 4, 2023 •
edited
Loading

Notion ticket link

N/A

Implementation description

  • Remove limits for max field size and number of files

Steps to test

  1. Upload a file less than 5MB (5.4MB on Mac). This should be successful.
  2. Upload a file more than 5MB (5.4MB on Mac). This should fail with an error message.

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

jfdoming
jfdoming approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@jfdoming jfdoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@carissa-tang carissa-tang merged commit 9d2f654 into staging Oct 4, 2023
5 checks passed
@carissa-tang carissa-tang deleted the carissa/remove-image-limit branch October 4, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfdoming jfdoming jfdoming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carissa-tang @jfdoming