-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding user profile fields #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes for consistency and also a nit: use imperative tense for commits + PR (e.g. Add rather than Adding).
Otherwise, looks good!!
backend/models/user.model.ts
Outdated
locationType: { | ||
type: String, | ||
required: true, | ||
enum: ["Remote", "Hybrid", "In Person"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the enum in userType you have "InPerson" and here its "In Person".
backend/types.ts
Outdated
@@ -1,5 +1,7 @@ | |||
export type Role = "Volunteer" | "Staff" | "Admin"; | |||
|
|||
export type LocationType = "Remote" | "Hybrid" | "In Person"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here, "InPerson" v.s "In Person"
…entre into braydon/add-user-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍👍👍
role: Role! | ||
locationType: LocationType | ||
headshot: String! | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason Ooh actually... nevermind!birthday
and locationType
are nullable?
I think startDate
, birthday
, locationType
, and headshot
should all be nullable (so no !
beside their types) because we don't provide this information to the query on the user's initial signup - the only information we pass when we register a user is their first name & last name, their email, and their password.
The decision between passing all this info to the query at once vs. in multiple steps is probably more of a PM question for later... but for now we should probably keep them nullable so the Sign Up page doesn't break :O
headshot: { | ||
type: String, | ||
required: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as before here: these probably shouldn't be required
- the current signup functionality will break :(
Notion Ticket Link
Add User Profile Fields
Implementation Description
Steps to Test
What should reviewers focus on?
Screenshots (optional)
Checklist
Linting & Formatting
Mac
Windows