Prevent zero length messages #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the design of the on-disk format of freezer, it does not support zero length messages. If we allow a zero length message to be written by the sink, it is indistinguishable om disk from the internally used end marker, and when being read as a source, is detected as a corrupt stream. Avoid this problem by explicitly dis-allowing empty messages and returning an error if the caller attempts to write one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the design of the on-disk format of freezer, it does not support
zero length messages. If we allow a zero length message to be written
by the sink, it is indistinguishable om disk from the internally used
end marker, and when being read as a source, is detected as a corrupt
stream.
Avoid this problem by explicitly dis-allowing empty messages and
returning an error if the caller attempts to write one.