Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug which caused primary_section_id to be null #226

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Fix bug which caused primary_section_id to be null #226

merged 4 commits into from
Sep 23, 2024

Conversation

fanglinfang
Copy link
Contributor

@fanglinfang fanglinfang commented Sep 21, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Sep 21, 2024 •
edited
Loading

Coverage Status

coverage: 92.668% (+0.01%) from 92.654%
when pulling 8f7c6a7 on develop
into 1d98db0 on main.

jlaney
jlaney requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@jlaney jlaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to handle the case where section_data.get("PrimarySection") returns None

@fanglinfang fanglinfang merged commit 577024c into main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaney jlaney jlaney approved these changes

@devights devights Awaiting requested review from devights

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanglinfang @coveralls @jlaney