Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] settings.range.min and settings.range.max do not inherit manually set date.min and date.max #292

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

uvarov-frontend
Copy link
Owner

Closes #289

@uvarov-frontend uvarov-frontend added the bug Something isn't working label Aug 17, 2024
@uvarov-frontend uvarov-frontend merged commit 30ea0cd into main Aug 17, 2024
1 check passed
@uvarov-frontend uvarov-frontend deleted the fix/289_-range branch August 17, 2024 09:46
@ghiscoding
Copy link
Contributor

@uvarov-frontend if I look at your PR, it looks like you partially rolled back my previous PR #254 since you removed Date | number input types. However you didn't rolled back the parseDates() changes that I've made in the other PR, so the min/max input might still work with a Date or number? I really wish to keep this, but I haven't tried your new version and it might still work (except for the types that you removed). If you really did remove this functionality, then it should probably added to your new 3.0 roadmap

@uvarov-frontend
Copy link
Owner Author

@uvarov-frontend if I look at your PR, it looks like you partially rolled back my previous PR #254 since you removed Date | number input types. However you didn't rolled back the parseDates() changes that I've made in the other PR, so the min/max input might still work with a Date or number? I really wish to keep this, but I haven't tried your new version and it might still work (except for the types that you removed). If you really did remove this functionality, then it should probably added to your new 3.0 roadmap

It didn’t work for date.min/max and range.min/max, so I deleted the types. It doesn’t use ‘parseDates’.

@ghiscoding
Copy link
Contributor

ah ok I'll have to take a look then, I still want to provide these types of input to the min/max settings. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] settings.range.min and settings.range.max do not inherit manually set date.min and date.max
2 participants