feat: change weekend days, fixes #283 #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR could be closed if not interested, I don't have time to work further on this anyway. It was just a quick test to see if what was asked in Discussion #283 is even possible. It kinda is possible (as shown above), but I'm not sure if you really would want to provide such feature... so feel free to close (or improve the PR and implement it as you see fit). Personally I would have preferred a setting like Cheers |
17 tasks
|
@ghiscoding @uvarov-frontend this is great! thanks for doing an exploration on this:) |
|
Implemented in v3.0.0 #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting to allow changing weekend days, for example Friday/Saturday instead of Saturday/Sunday as per Discussion #283
However, it's currently broken when enabling
iso8601: true, that would have to be fixed but I don't have more time to look into this. There's also probably a lot more code that calculate days/weekends somewhere else, so it's quite possible that I didn't cover everything. I assume that theiso8601could probably be ignored but we would probably also need another setting to know which day is the starting (for example start on Sunday or Monday or even Tuesday)