Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find: Implement -ok[dir] predicate. #369

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hanbings
Copy link
Collaborator

implement: #8

@cakebaker cakebaker linked an issue May 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 66.32%. Comparing base (e3f4224) to head (18b88ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/find/matchers/exec.rs 0.00% 9 Missing and 1 partial ⚠️
src/find/matchers/mod.rs 33.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   66.51%   66.32%   -0.19%     
==========================================
  Files          36       36              
  Lines        4366     4380      +14     
  Branches      982      984       +2     
==========================================
+ Hits         2904     2905       +1     
- Misses       1062     1072      +10     
- Partials      400      403       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Sponsor Contributor

@hanbings do you have an update on this ? thanks :)

path_to_file.to_string_lossy()
);
#[allow(clippy::explicit_write)]
write!(stdout(), "{}", tips).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POSIX specifies

  • The -ok primary shall write a prompt to standard error
  • In the POSIX locale, the last non-<blank> in the prompt shall be '?'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I overlooked these, I will fix them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureComplete: implement ok[dir] predicate
3 participants