Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp: copy attributes after making subdir #6884

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cp: copy attributes after making subdir #6884

wants to merge 2 commits into from

Conversation

rm-dr
Copy link

@rm-dr rm-dr commented Nov 23, 2024 •
edited
Loading

@rm-dr rm-dr marked this pull request as draft November 23, 2024 23:14
@rm-dr rm-dr changed the title opy attributes after making subdir Copy attributes after making subdir Nov 23, 2024
@rm-dr rm-dr force-pushed the 6875-cp-a branch 2 times, most recently from 898a027 to 6676cde Compare November 23, 2024 23:56
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/cp-HL. tests/cp/cp-HL is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/cp-deref. tests/cp/cp-deref is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/dir-slash. tests/cp/dir-slash is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/fail-perm. tests/cp/fail-perm is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/link-preserve. tests/cp/link-preserve is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/parent-perm-race. tests/cp/parent-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/symlink-slash. tests/cp/symlink-slash is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/dup-source. tests/mv/dup-source is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
GNU test error: tests/cp/link-heap. tests/cp/link-heap is passing on 'main'. Maybe you have to rebase?

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@rm-dr rm-dr marked this pull request as ready for review November 24, 2024 17:09
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/link-heap. tests/cp/link-heap is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker changed the title Copy attributes after making subdir cp: copy attributes after making subdir Nov 25, 2024
sylvestre
sylvestre reviewed Nov 25, 2024
View reviewed changes
src/uu/cp/src/copydir.rs
fn build_dir(
path: &PathBuf,
recursive: bool,
options: &Options,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing the order?

sylvestre
sylvestre reviewed Nov 25, 2024
View reviewed changes
tests/by-util/test_cp.rs
Comment on lines +3379 to +3386
// Copy the directory, preserving those permissions.
//
// preserve permissions (mode, ownership, timestamps)
// | copy directories recursively
// | | from this source directory
// | | | to this destination
// | | | |
// V V V V
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this comment :)
it is quite obvious

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/link-heap. tests/cp/link-heap is passing on 'main'. Maybe you have to rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cp -a does not copy attributes (owner, rights) of directories
2 participants
@rm-dr @sylvestre