Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DENA-658 - new bases for github-arc #347

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Conversation

fillyD
Copy link
Contributor

@fillyD fillyD commented Jul 19, 2024

scripting to pull-upstream and update crds/templates will be added later after we get a provisional setup working first

@fillyD fillyD requested a review from a team as a code owner July 19, 2024 08:58
Copy link

linear bot commented Jul 19, 2024

@fillyD fillyD marked this pull request as draft July 19, 2024 09:23
spec:
initContainers:
- name: kube-init
image: ghcr.io/actions/actions-runner:2.317.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be a nice to have this update along with the chart version somehow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure much can be done about this. we can use latest tag if this introduces an unwanted overhead.

maxRunners: 5
minRunners: 1

runnerScaleSetName: "cluster-os-kubernetes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translates to a name here: https://github.com/organizations/utilitywarehouse/settings/actions/runners

Our current runners have this label in exp-1-merit: uw-infra-exp - whats the best way to set this for different envs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll try patching from the kustomize in kubernetes-manifests. will leave to just this for now until there is a requirement to deploy multiple runnerSets in a single namespace otherwise we will have to rename a lot more

  - target:
      kind: AutoscalingRunnerSet
      name: cluster-os-kubernetes
    patch: |-
      - op: replace
        path: "/spec/runnerScaleSetName"
        value: exp-1-merit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants