-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: DENA-658 - new bases for github-arc #347
base: master
Are you sure you want to change the base?
Conversation
- Rename namespaced resources for now
- make target to generate all manifests
spec: | ||
initContainers: | ||
- name: kube-init | ||
image: ghcr.io/actions/actions-runner:2.317.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be a nice to have this update along with the chart version somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure much can be done about this. we can use latest tag if this introduces an unwanted overhead.
maxRunners: 5 | ||
minRunners: 1 | ||
|
||
runnerScaleSetName: "cluster-os-kubernetes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This translates to a name here: https://github.com/organizations/utilitywarehouse/settings/actions/runners
Our current runners have this label in exp-1-merit
: uw-infra-exp
- whats the best way to set this for different envs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll try patching from the kustomize in kubernetes-manifests. will leave to just this for now until there is a requirement to deploy multiple runnerSets in a single namespace otherwise we will have to rename a lot more
- target:
kind: AutoscalingRunnerSet
name: cluster-os-kubernetes
patch: |-
- op: replace
path: "/spec/runnerScaleSetName"
value: exp-1-merit
scripting to pull-upstream and update crds/templates will be added later after we get a provisional setup working first