Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tempo reads from sampled spans topic #733

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

matthewhughes-uw
Copy link
Contributor

Ticket: DENA-1126

Copy link

linear bot commented Dec 17, 2024

@matthewhughes-uw matthewhughes-uw marked this pull request as ready for review December 17, 2024 15:24
@matthewhughes-uw matthewhughes-uw requested a review from a team as a code owner December 17, 2024 15:24
@uw-infra
Copy link

uw-infra commented Dec 17, 2024

Terraform run output for

Cluster: dev-aws
Module: otel/kafka-bitnami
Path: dev-aws/otel
Commit ID: 7bb3af05e67659ad5b2746439bfc06d17534eb2a
✅ Run Status: Ok, Run Summary: Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=otel/tempo-distributor"
      + id                           = (known after apply)
      + resource_name                = "otel.otlp_sampled_spans"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/otel as comment.

@matthewhughes-uw matthewhughes-uw merged commit 0b607e7 into main Dec 17, 2024
2 checks passed
@matthewhughes-uw matthewhughes-uw deleted the mhughes-DENA-1126-update-tempo branch December 17, 2024 15:25
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: otel/kafka-bitnami
Path: dev-aws/otel
Commit ID: 0b607e7cf9fef84753364c30f347f7c6f51b9abd
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 1 added, 0 changed, 0 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=otel/tempo-distributor"
      + id                           = (known after apply)
      + resource_name                = "otel.otlp_sampled_spans"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"]: Creating...
module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"]: Creation complete after 0s [id=User:CN=otel/tempo-distributor|*|Read|Allow|Topic|otel.otlp_sampled_spans|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 14, in provider "kafka":
  14: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `ca_cert` instead.

(and 2 more similar warnings elsewhere)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/otel as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants