Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing consumer group for sampling collector #729

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

matthewhughes-uw
Copy link
Contributor

Ticket: DENA-1126

@matthewhughes-uw matthewhughes-uw requested a review from a team as a code owner December 13, 2024 12:24
Copy link

linear bot commented Dec 13, 2024

@uw-infra
Copy link

uw-infra commented Dec 13, 2024

Terraform run output for

Cluster: dev-aws
Module: otel/kafka-bitnami
Path: dev-aws/otel
Commit ID: 043dbac689fdfe93719f9630ea751c805eb6ef53
✅ Run Status: Ok, Run Summary: Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=otel/tail-sampling-collector"
      + id                           = (known after apply)
      + resource_name                = "otel.tail-sampling-collector"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/otel as comment.

@matthewhughes-uw matthewhughes-uw merged commit e6749ae into main Dec 13, 2024
2 checks passed
@matthewhughes-uw matthewhughes-uw deleted the mhughes-DENA-1126-fix branch December 13, 2024 12:30
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: otel/kafka-bitnami
Path: dev-aws/otel
Commit ID: e6749aef789070d22466dd830466bfc2bab3f660
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 1 added, 0 changed, 0 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=otel/tail-sampling-collector"
      + id                           = (known after apply)
      + resource_name                = "otel.tail-sampling-collector"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"]: Creating...
module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"]: Creation complete after 1s [id=User:CN=otel/tail-sampling-collector|*|Read|Allow|Group|otel.tail-sampling-collector|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 14, in provider "kafka":
  14: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `ca_cert` instead.

(and 2 more similar warnings elsewhere)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/otel as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants