-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic and app for new otel collector #727
Conversation
Terraform run output for
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# kafka_topic.otlp_sampled_spans will be created
+ resource "kafka_topic" "otlp_sampled_spans" {
+ config = {
+ "cleanup.policy" = "delete"
+ "compression.type" = "zstd"
+ "max.message.bytes" = "134217728"
+ "retention.bytes" = "5368709120"
+ "retention.ms" = "43200000"
+ "segment.bytes" = "262144000"
+ "segment.ms" = "10800000"
}
+ id = (known after apply)
+ name = "otel.otlp_sampled_spans"
+ partitions = 200
+ replication_factor = 3
}
# module.otel_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "producer_acl" {
+ acl_host = "*"
+ acl_operation = "Write"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.otel_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
Plan: 3 to add, 0 to change, 0 to destroy.
|
Terraform run output for
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# kafka_topic.otlp_sampled_spans will be created
+ resource "kafka_topic" "otlp_sampled_spans" {
+ config = {
+ "cleanup.policy" = "delete"
+ "compression.type" = "zstd"
+ "max.message.bytes" = "134217728"
+ "retention.bytes" = "5368709120"
+ "retention.ms" = "43200000"
+ "segment.bytes" = "262144000"
+ "segment.ms" = "10800000"
}
+ id = (known after apply)
+ name = "otel.otlp_sampled_spans"
+ partitions = 200
+ replication_factor = 3
}
# module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "producer_acl" {
+ acl_host = "*"
+ acl_operation = "Write"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
Plan: 3 to add, 0 to change, 0 to destroy.
|
The new tail sampler will: * Read from the current `otel.otlp_spans` topic * Produce to the new `otel.otlp_sampled_spans` Later `tempo` will also be configure to read from the new topic and not the old one, but we'll leave it alone for now. Ticket: DENA-1126
e66ffd6
to
12aa980
Compare
Terraform run output for
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# kafka_topic.otlp_sampled_spans will be created
+ resource "kafka_topic" "otlp_sampled_spans" {
+ config = {
+ "cleanup.policy" = "delete"
+ "compression.type" = "zstd"
+ "max.message.bytes" = "134217728"
+ "retention.bytes" = "5368709120"
+ "retention.ms" = "43200000"
+ "segment.bytes" = "262144000"
+ "segment.ms" = "10800000"
}
+ id = (known after apply)
+ name = "otel.otlp_sampled_spans"
+ partitions = 200
+ replication_factor = 3
}
# module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "producer_acl" {
+ acl_host = "*"
+ acl_operation = "Write"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
Plan: 3 to add, 0 to change, 0 to destroy.
|
Terraform run output for
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 3 added, 0 changed, 0 destroyedTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# kafka_topic.otlp_sampled_spans will be created
+ resource "kafka_topic" "otlp_sampled_spans" {
+ config = {
+ "cleanup.policy" = "delete"
+ "compression.type" = "zstd"
+ "max.message.bytes" = "134217728"
+ "retention.bytes" = "5368709120"
+ "retention.ms" = "43200000"
+ "segment.bytes" = "262144000"
+ "segment.ms" = "10800000"
}
+ id = (known after apply)
+ name = "otel.otlp_sampled_spans"
+ partitions = 200
+ replication_factor = 3
}
# module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "producer_acl" {
+ acl_host = "*"
+ acl_operation = "Write"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
Plan: 3 to add, 0 to change, 0 to destroy.
kafka_topic.otlp_sampled_spans: Creating...
module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"]: Creating...
module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"]: Creation complete after 1s [id=User:CN=otel/tail-sampling-collector|*|Read|Allow|Topic|otel.otlp_spans|Literal]
kafka_topic.otlp_sampled_spans: Creation complete after 2s [id=otel.otlp_sampled_spans]
module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"]: Creating...
module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"]: Creation complete after 0s [id=User:CN=otel/tail-sampling-collector|*|Write|Allow|Topic|otel.otlp_sampled_spans|Literal]
Warning: Argument is deprecated
with provider["registry.terraform.io/mongey/kafka"],
on __env.tf line 14, in provider "kafka":
14: provider "kafka" {
This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.
(and 2 more similar warnings elsewhere)
Apply complete! Resources: 3 added, 0 changed, 0 destroyed.
|
The new tail sampler will:
otel.otlp_spans
topicotel.otlp_sampled_spans
Later
tempo
will also be configure to read from the new topic and not the old one, but we'll leave it alone for now.Ticket: DENA-1126